feat: Integrated native ACVM #4903

PhilWindle · 2024-03-03T17:10:58Z

This PR creates a cli entrypoint for the ACVM simulator, builds it and makes it available for use in e2e tests both locally and on CI.

This native simulator is used to execute sequencer-side protocol circuits, in parallel where possible.

AztecBot · 2024-03-03T18:07:10Z

Benchmark results

Metrics with a significant change:

circuit_simulation_time_in_ms (base-rollup): 658 (-53%)
l2_block_building_time_in_ms (8): 11,276 (-36%)
l2_block_building_time_in_ms (32): 44,877 (-35%)
l2_block_building_time_in_ms (64): 89,631 (-37%)
l2_block_rollup_simulation_time_in_ms (8): 7,322 (-46%)
l2_block_rollup_simulation_time_in_ms (32): 29,347 (-45%)
l2_block_rollup_simulation_time_in_ms (64): 58,648 (-46%)
note_trial_decrypting_time_in_ms (8): 111 (+1144%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 06a91169 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,384	239,420	470,216
l1_rollup_execution_gas	194,332	500,726	909,474
l2_block_processing_time_in_ms	1,192 (+1%)	4,476	8,920
note_successful_decrypting_time_in_ms	198 (-2%)	540 (-1%)	1,001
note_trial_decrypting_time_in_ms	⚠️ 111 (+1144%)	61.4 (-15%)	33.9 (-75%)
l2_block_building_time_in_ms	⚠️ 11,276 (-36%)	⚠️ 44,877 (-35%)	⚠️ 89,631 (-37%)
l2_block_rollup_simulation_time_in_ms	⚠️ 7,322 (-46%)	⚠️ 29,347 (-45%)	⚠️ 58,648 (-46%)
l2_block_public_tx_process_time_in_ms	3,925 (-3%)	15,459 (-5%)	30,868 (-7%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,199 (-15%)	27,360 (-3%)
note_history_successful_decrypting_time_in_ms	1,243 (-1%)	2,434 (-1%)
note_history_trial_decrypting_time_in_ms	89.6 (+3%)	139 (-22%)
node_database_size_in_bytes	18,776,144	35,332,176
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	255 (-1%)	44,736	28,001
private-kernel-ordering	194 (-2%)	52,625	14,627
base-rollup	⚠️ 658 (-53%)	177,932	997
root-rollup	68.8 (-7%)	4,320	825
private-kernel-inner	323 (-3%)	73,715	28,001
public-kernel-app-logic	173 (-15%)	32,254	25,379
merge-rollup	8.55 (-6%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.78 (-2%)	10.2 (-7%)	15.2 (+21%)	16.1 (-1%)	21.8 (-1%)	35.5	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.568 (-2%)	0.569 (-7%)	0.647 (+22%)	0.496 (-1%)	0.458 (-1%)	0.443	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.8 (-1%)	71.8 (-4%)	231	446 (-1%)	867	1,717 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.469 (-1%)	0.443 (-4%)	0.421	0.418	0.413 (-1%)	0.412 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.0 (-4%)	107	338 (+1%)	659 (-1%)	1,307	2,614
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.481 (-3%)	0.481	0.461 (+1%)	0.454	0.454	0.453
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.1 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,712 (+2%)	1,379 (-2%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0309 (+3%)	480 (-3%)

socket-security · 2024-03-04T12:14:04Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

… into pw/acvm-sim

yarn-project/Dockerfile.prod

yarn-project/aztec/Dockerfile

noir/noir-repo/tooling/acvm_cli/src/cli/fs/inputs.rs

noir/noir-repo/tooling/acvm_cli/src/cli/mod.rs

yarn-project/end-to-end/src/fixtures/utils.ts

yarn-project/noir-protocol-circuits-types/src/index.ts

yarn-project/sequencer-client/src/block_builder/solo_block_builder.ts

yarn-project/sequencer-client/src/simulator/acvm_native.ts

yarn-project/sequencer-client/src/simulator/public_kernel.ts

alexghr

Code looks good, but I'm surprised to see some of the circuits take longer to complete in the bench e2e test (according to the comment). Assuming that the bench uses the native simulator, could the slowdown come from mapping data and writing/reading to disk?

Later edit: looks like switching back to WASM for the smaller circuits completely fixed the perf regressions 🥳

alexghr

🔥

… into pw/acvm-sim

This PR creates a cli entrypoint for the ACVM simulator, builds it and makes it available for use in e2e tests both locally and on CI. This native simulator is used to execute sequencer-side protocol circuits, in parallel where possible.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.5</summary> ## [0.26.5](aztec-package-v0.26.4...aztec-package-v0.26.5) (2024-03-07) ### Features * Integrated native ACVM ([#4903](#4903)) ([3fd7025](3fd7025)) </details> <details><summary>barretenberg.js: 0.26.5</summary> ## [0.26.5](barretenberg.js-v0.26.4...barretenberg.js-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.5</summary> ## [0.26.5](aztec-cli-v0.26.4...aztec-cli-v0.26.5) (2024-03-07) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.5</summary> ## [0.26.5](aztec-packages-v0.26.4...aztec-packages-v0.26.5) (2024-03-07) ### Features * Crowdfunding contract ([#4917](#4917)) ([ba3aff2](ba3aff2)) * Integrated native ACVM ([#4903](#4903)) ([3fd7025](3fd7025)) ### Bug Fixes * Dependency for yarn-project-tests ([#5031](#5031)) ([4b5db50](4b5db50)) * **docs:** Update writing_token_contract.md ([#5020](#5020)) ([5b0f38f](5b0f38f)) * End to end dependency fix ([#5029](#5029)) ([191ad93](191ad93)) * Missing dependency end-to-end => yarn-project ([#5018](#5018)) ([f930bdd](f930bdd)) * **revert:** "feat(avm): storage" ([#5019](#5019)) ([ba31016](ba31016)) ### Miscellaneous * **boxes:** Refactor npx to improve readability, added upgrade option and manual versioning ([#4855](#4855)) ([ef76d3f](ef76d3f)) * Purging calldata hash ([#4984](#4984)) ([f6f34b7](f6f34b7)) ### Documentation * Add versions section to updating doc ([#4916](#4916)) ([d4d935f](d4d935f)) </details> <details><summary>barretenberg: 0.26.5</summary> ## [0.26.5](barretenberg-v0.26.4...barretenberg-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-package-v0.26.4...aztec-package-v0.26.5) (2024-03-07) ### Features * Integrated native ACVM ([#4903](AztecProtocol/aztec-packages#4903)) ([3fd7025](AztecProtocol/aztec-packages@3fd7025)) </details> <details><summary>barretenberg.js: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@barretenberg.js-v0.26.4...barretenberg.js-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-cli-v0.26.4...aztec-cli-v0.26.5) (2024-03-07) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-packages-v0.26.4...aztec-packages-v0.26.5) (2024-03-07) ### Features * Crowdfunding contract ([#4917](AztecProtocol/aztec-packages#4917)) ([ba3aff2](AztecProtocol/aztec-packages@ba3aff2)) * Integrated native ACVM ([#4903](AztecProtocol/aztec-packages#4903)) ([3fd7025](AztecProtocol/aztec-packages@3fd7025)) ### Bug Fixes * Dependency for yarn-project-tests ([#5031](AztecProtocol/aztec-packages#5031)) ([4b5db50](AztecProtocol/aztec-packages@4b5db50)) * **docs:** Update writing_token_contract.md ([#5020](AztecProtocol/aztec-packages#5020)) ([5b0f38f](AztecProtocol/aztec-packages@5b0f38f)) * End to end dependency fix ([#5029](AztecProtocol/aztec-packages#5029)) ([191ad93](AztecProtocol/aztec-packages@191ad93)) * Missing dependency end-to-end => yarn-project ([#5018](AztecProtocol/aztec-packages#5018)) ([f930bdd](AztecProtocol/aztec-packages@f930bdd)) * **revert:** "feat(avm): storage" ([#5019](AztecProtocol/aztec-packages#5019)) ([ba31016](AztecProtocol/aztec-packages@ba31016)) ### Miscellaneous * **boxes:** Refactor npx to improve readability, added upgrade option and manual versioning ([#4855](AztecProtocol/aztec-packages#4855)) ([ef76d3f](AztecProtocol/aztec-packages@ef76d3f)) * Purging calldata hash ([#4984](AztecProtocol/aztec-packages#4984)) ([f6f34b7](AztecProtocol/aztec-packages@f6f34b7)) ### Documentation * Add versions section to updating doc ([#4916](AztecProtocol/aztec-packages#4916)) ([d4d935f](AztecProtocol/aztec-packages@d4d935f)) </details> <details><summary>barretenberg: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@barretenberg-v0.26.4...barretenberg-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Automated pull of Noir development from [aztec-packages](https://github.com/AztecProtocol/aztec-packages). BEGIN_COMMIT_OVERRIDE chore!: Remove open keyword from Noir (AztecProtocol/aztec-packages#4967) chore: aztec-macros refactor (AztecProtocol/aztec-packages#5127) feat: make brillig-gen more AVM-friendly (AztecProtocol/aztec-packages#5091) feat: Integrated native ACVM (AztecProtocol/aztec-packages#4903) END_COMMIT_OVERRIDE --------- Co-authored-by: sirasistant <sirasistant@gmail.com> Co-authored-by: Maddiaa <47148561+Maddiaa0@users.noreply.github.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: TomAFrench <tom@tomfren.ch> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>0.26.0</summary> ## [0.26.0](v0.25.0...v0.26.0) (2024-03-25) ### ⚠ BREAKING CHANGES * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) * automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) * separating out array and slice types in the AST ([#4504](#4504)) * Acir call opcode (AztecProtocol/aztec-packages#4773) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) * Remove open keyword from Noir (AztecProtocol/aztec-packages#4967) ### Features * Acir call opcode (AztecProtocol/aztec-packages#4773) ([c3c9e19](c3c9e19)) * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) ([13eb71b](13eb71b)) * Add `break` and `continue` in unconstrained code ([#4569](#4569)) ([f2f827d](f2f827d)) * Add `nargo compile --watch` command ([#4464](#4464)) ([44e60b6](44e60b6)) * Add as_slice builtin function, add execution test ([#4523](#4523)) ([6a9ea35](6a9ea35)) * Add checks for bit size consistency on brillig gen ([#4542](#4542)) ([f3243b7](f3243b7)) * Add CMOV instruction to brillig and brillig gen (AztecProtocol/aztec-packages#5308) ([13eb71b](13eb71b)) * Add experimental `quote` expression to parser ([#4595](#4595)) ([4c3a30b](4c3a30b)) * Add more impls on Option ([#4549](#4549)) ([4cf700b](4cf700b)) * Add specific error for attempting `string[x] = ".."` ([#4611](#4611)) ([ff95fd9](ff95fd9)) * Allow usage of noir `#[test]` syntax in stdlib ([#4553](#4553)) ([a8b7cdb](a8b7cdb)) * Automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) ([13eb71b](13eb71b)) * **avm:** Brillig CONST of size > u128 (AztecProtocol/aztec-packages#5217) ([c3c9e19](c3c9e19)) * Brillig IR refactor (AztecProtocol/aztec-packages#5233) ([c3c9e19](c3c9e19)) * Check initialization arguments in constructors (AztecProtocol/aztec-packages#5144) ([d4213a0](d4213a0)) * Check initializer msg.sender matches deployer from address preimage (AztecProtocol/aztec-packages#5222) ([c3c9e19](c3c9e19)) * Initial Earthly CI (AztecProtocol/aztec-packages#5069) ([c3c9e19](c3c9e19)) * Integrated native ACVM (AztecProtocol/aztec-packages#4903) ([a6016b4](a6016b4)) * Make brillig-gen more AVM-friendly (AztecProtocol/aztec-packages#5091) ([a6016b4](a6016b4)) * New brillig field operations and refactor of binary operations (AztecProtocol/aztec-packages#5208) ([c3c9e19](c3c9e19)) * Optimize sha2 implementation ([#4441](#4441)) ([80373d6](80373d6)) * RC optimization pass ([#4560](#4560)) ([dfa5126](dfa5126)) * Remove curly braces with fmt ([#4529](#4529)) ([fe9a437](fe9a437)) * Separating out array and slice types in the AST ([#4504](#4504)) ([9a241f9](9a241f9)) * Signed integer division and modulus in brillig gen (AztecProtocol/aztec-packages#5279) ([c3c9e19](c3c9e19)) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) ([c3c9e19](c3c9e19)) * Sync from noir (AztecProtocol/aztec-packages#5234) ([c3c9e19](c3c9e19)) * Sync from noir (AztecProtocol/aztec-packages#5286) ([c3c9e19](c3c9e19)) * Visible aliases for nargo commands ([#4453](#4453)) ([773cf19](773cf19)) ### Bug Fixes * **acir_gen:** More granular element sizes array check ([#4528](#4528)) ([f93d16e](f93d16e)) * Added error messages for passing oracles and references from unconstrained to constrained functions ([#4570](#4570)) ([265bd8b](265bd8b)) * Allow non-integer globals to reference struct methods ([#4490](#4490)) ([00d6494](00d6494)) * Dynamic assert messages in brillig ([#4531](#4531)) ([e24d3fc](e24d3fc)) * Evaluate operators in globals in types ([#4537](#4537)) ([c8aa16b](c8aa16b)) * Make `nargo` the default binary for cargo run ([#4554](#4554)) ([de4986e](de4986e)) * Signed integer comparisons in brillig ([#4579](#4579)) ([938d5e8](938d5e8)) * **ssa:** Use accurate type during SSA AsSlice simplficiation ([#4610](#4610)) ([0473497](0473497)) * Substitute generics when checking the field count of a type ([#4547](#4547)) ([eeeebac](eeeebac)) ### Miscellaneous Chores * Remove open keyword from Noir (AztecProtocol/aztec-packages#4967) ([a6016b4](a6016b4)) </details> <details><summary>0.42.0</summary> ## [0.42.0](v0.41.0...v0.42.0) (2024-03-25) ### ⚠ BREAKING CHANGES * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) * automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) * Acir call opcode (AztecProtocol/aztec-packages#4773) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) * Internal as a macro (AztecProtocol/aztec-packages#4898) * move noir out of yarn-project (AztecProtocol/aztec-packages#4479) * note type ids (AztecProtocol/aztec-packages#4500) * rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) * Add expression width into acir (AztecProtocol/aztec-packages#4014) * init storage macro (AztecProtocol/aztec-packages#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) * Sync commits from `aztec-packages` ([#4144](#4144)) * Breaking changes from aztec-packages ([#3955](#3955)) * Rename Arithmetic opcode to AssertZero ([#3840](#3840)) * Remove unused methods on ACIR opcodes ([#3841](#3841)) * Remove partial backend feature ([#3805](#3805)) ### Features * Acir call opcode (AztecProtocol/aztec-packages#4773) ([c3c9e19](c3c9e19)) * **acir:** Program and witness stack structure (AztecProtocol/aztec-packages#5149) ([13eb71b](13eb71b)) * Add bit size to const opcode (AztecProtocol/aztec-packages#4385) ([158c8ce](158c8ce)) * Add CMOV instruction to brillig and brillig gen (AztecProtocol/aztec-packages#5308) ([13eb71b](13eb71b)) * Add expression width into acir (AztecProtocol/aztec-packages#4014) ([158c8ce](158c8ce)) * Add instrumentation for tracking variables in debugging ([#4122](#4122)) ([c58d691](c58d691)) * Add poseidon2 opcode implementation for acvm/brillig, and Noir ([#4398](#4398)) ([10e8292](10e8292)) * Add support for overriding expression width ([#4117](#4117)) ([c8026d5](c8026d5)) * Added cast opcode and cast calldata (AztecProtocol/aztec-packages#4423) ([78ef013](78ef013)) * Allow brillig to read arrays directly from memory (AztecProtocol/aztec-packages#4460) ([158c8ce](158c8ce)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol/aztec-packages#4478) ([158c8ce](158c8ce)) * Allow variables and stack trace inspection in the debugger ([#4184](#4184)) ([bf263fc](bf263fc)) * Automatic NoteInterface and NoteGetterOptions auto select (AztecProtocol/aztec-packages#4508) ([13eb71b](13eb71b)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol/aztec-packages#4438) ([158c8ce](158c8ce)) * **avm:** Brillig CONST of size > u128 (AztecProtocol/aztec-packages#5217) ([c3c9e19](c3c9e19)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol/aztec-packages#4400) ([158c8ce](158c8ce)) * Aztec-packages ([#3754](#3754)) ([c043265](c043265)) * Backpropagate constants in ACIR during optimization ([#3926](#3926)) ([aad0da0](aad0da0)) * Breaking changes from aztec-packages ([#3955](#3955)) ([5be049e](5be049e)) * Brillig IR refactor (AztecProtocol/aztec-packages#5233) ([c3c9e19](c3c9e19)) * Check initializer msg.sender matches deployer from address preimage (AztecProtocol/aztec-packages#5222) ([c3c9e19](c3c9e19)) * Evaluation of dynamic assert messages ([#4101](#4101)) ([c284e01](c284e01)) * Init storage macro (AztecProtocol/aztec-packages#4200) ([158c8ce](158c8ce)) * Initial Earthly CI (AztecProtocol/aztec-packages#5069) ([c3c9e19](c3c9e19)) * Internal as a macro (AztecProtocol/aztec-packages#4898) ([5f57ebb](5f57ebb)) * New brillig field operations and refactor of binary operations (AztecProtocol/aztec-packages#5208) ([c3c9e19](c3c9e19)) * Note type ids (AztecProtocol/aztec-packages#4500) ([78ef013](78ef013)) * Remove range constraints from witnesses which are constrained to be constants ([#3928](#3928)) ([afe9c7a](afe9c7a)) * Remove replacement of boolean range opcodes with `AssertZero` opcodes ([#4107](#4107)) ([dac0e87](dac0e87)) * Signed integer division and modulus in brillig gen (AztecProtocol/aztec-packages#5279) ([c3c9e19](c3c9e19)) * Speed up transformation of debug messages ([#3815](#3815)) ([2a8af1e](2a8af1e)) * Support contracts with no constructor (AztecProtocol/aztec-packages#5175) ([c3c9e19](c3c9e19)) * Sync `aztec-packages` ([#4011](#4011)) ([fee2452](fee2452)) * Sync commits from `aztec-packages` ([#4068](#4068)) ([7a8f3a3](7a8f3a3)) * Sync commits from `aztec-packages` ([#4144](#4144)) ([0205d3b](0205d3b)) * Sync from aztec-packages ([#4483](#4483)) ([fe8f277](fe8f277)) * Sync from noir (AztecProtocol/aztec-packages#5234) ([c3c9e19](c3c9e19)) * Sync from noir (AztecProtocol/aztec-packages#5286) ([c3c9e19](c3c9e19)) ### Bug Fixes * Deserialize odd length hex literals ([#3747](#3747)) ([4000fb2](4000fb2)) * Noir test incorrect reporting (AztecProtocol/aztec-packages#4925) ([5f57ebb](5f57ebb)) * Remove panic from `init_log_level` in `acvm_js` ([#4195](#4195)) ([2e26530](2e26530)) * Return error rather instead of panicking on invalid circuit ([#3976](#3976)) ([67201bf](67201bf)) ### Miscellaneous Chores * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) ([158c8ce](158c8ce)) * Move noir out of yarn-project (AztecProtocol/aztec-packages#4479) ([78ef013](78ef013)) * Remove partial backend feature ([#3805](#3805)) ([0383100](0383100)) * Remove unused methods on ACIR opcodes ([#3841](#3841)) ([9e5d0e8](9e5d0e8)) * Rename Arithmetic opcode to AssertZero ([#3840](#3840)) ([836f171](836f171)) * Rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) ([158c8ce](158c8ce)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

PhilWindle added 2 commits March 3, 2024 17:10

Initial commit

e141d30

Fixes

73fef6b

PhilWindle added 3 commits March 4, 2024 10:14

Merge branch 'master' into pw/acvm-sim

fd8714c

Updated rebuild patterns

1eef3b3

Fixes

82a8bfb

PhilWindle added 4 commits March 4, 2024 12:14

Cleanup

31de2e6

Fixes

5d17ada

Cleanup

b70afd6

Comments

bbc4f10

PhilWindle marked this pull request as ready for review March 4, 2024 12:59

PhilWindle requested a review from charlielye as a code owner March 4, 2024 12:59

PhilWindle and others added 11 commits March 4, 2024 12:59

Merge branch 'master' into pw/acvm-sim

fd7969d

Formatting

d231e4e

Merge branch 'pw/acvm-sim' of github.com:AztecProtocol/aztec-packages…

32719b8

… into pw/acvm-sim

Fixes

33ec2d4

Lock file

88cada1

Test

c1f13bc

Attempt fix

2502ec8

Fixes

10f99d1

Removed nargo

9720e26

Comment

3aa5141

Fix

0b42c30

spalladino reviewed Mar 4, 2024

View reviewed changes

PhilWindle added 3 commits March 4, 2024 20:55

Formatting

60b9c11

Fix

c7b50e8

Review changes

3fad6f1

TomAFrench self-requested a review March 4, 2024 23:44

Review changes

f894f85

PhilWindle added 3 commits March 6, 2024 10:15

Try again

9e0cce3

Try again

4a47fbd

Try again

3486cb0

alexghr reviewed Mar 6, 2024

View reviewed changes

PhilWindle and others added 9 commits March 6, 2024 12:20

Merge branch 'master' into pw/acvm-sim

c7d2fcb

Upgrade e2e test machines

b426f52

Upgrade e2e machines

532e065

Force re-run

d0f61f4

Use WASM for small circuits

eef61ae

Revert machine upgrade

2857617

Capture average circuit simulation times

a3ead17

Formatting

8391b8e

Merge branch 'master' into pw/acvm-sim

3ea825f

alexghr approved these changes Mar 6, 2024

View reviewed changes

just-mitch approved these changes Mar 6, 2024

View reviewed changes

PhilWindle added 3 commits March 6, 2024 17:49

Build fix

392b770

Merge branch 'pw/acvm-sim' of github.com:AztecProtocol/aztec-packages…

8c710ed

… into pw/acvm-sim

Formatting

9201823

PhilWindle merged commit 3fd7025 into master Mar 6, 2024
95 checks passed

PhilWindle deleted the pw/acvm-sim branch March 6, 2024 22:36

AztecBot mentioned this pull request Mar 6, 2024

chore(master): Release 0.26.5 #4995

Merged

AztecBot mentioned this pull request Mar 6, 2024

feat: Sync from aztec-packages noir-lang/noir#4494

Merged

kevaundray mentioned this pull request Mar 13, 2024

chore: Release Noir(0.26.0) noir-lang/noir#4526

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Integrated native ACVM #4903

feat: Integrated native ACVM #4903

PhilWindle commented Mar 3, 2024 •

edited

Loading

AztecBot commented Mar 3, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

socket-security bot commented Mar 4, 2024 •

edited

Loading

alexghr left a comment •

edited

Loading

alexghr left a comment

feat: Integrated native ACVM #4903

feat: Integrated native ACVM #4903

Conversation

PhilWindle commented Mar 3, 2024 • edited Loading

AztecBot commented Mar 3, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

socket-security bot commented Mar 4, 2024 • edited Loading

alexghr left a comment • edited Loading

Choose a reason for hiding this comment

alexghr left a comment

Choose a reason for hiding this comment

PhilWindle commented Mar 3, 2024 •

edited

Loading

AztecBot commented Mar 3, 2024 •

edited

Loading

socket-security bot commented Mar 4, 2024 •

edited

Loading

alexghr left a comment •

edited

Loading